Closed tobiasschweizer closed 5 years ago
Actually I want to add a test for this :-)
@tobiasschweizer that is of course necessary to be on the safe side!
We need more tests. I am trying to understand how to write them. It turns out to be non trivial since you have to mock what does not belong to your test.
When doing an extended search, a subscription to
SearchParamsService
is acquired inSearchResultsComponent
.When
SearchResultsComponent
is destroyed, the subscription has to be cancelled. Otherwise the old subscriptions are still active, causing unnecessary calls to the Knora API.