search

dasch-swiss / beol

Bernoulli-Euler OnLine
https://beol.dasch.swiss
GNU Affero General Public License v3.0
0 stars 1 forks source link

Introduction component #85

Closed tobiasschweizer closed 5 years ago

tobiasschweizer commented 5 years ago

The JSON representing the introduction's structure was obtained asynchronously. This was unnecessary.

Also I could get rid of NavigationEnd (Subscription). Now the component only listens to changed parameters. Previously a reload was triggered also when the user opened the subelements of an active item.

fixes #60

tobiasschweizer commented 5 years ago

@SepidehAlassi Does this work for you?

SepidehAlassi commented 5 years ago

@tobiasschweizer yes this works. However, the introduction component is currently specific to Goldbach volume. It should be made generic. you can go ahead and merge this. I will continue working on the introduction in "Condorcet" branch.

tobiasschweizer commented 5 years ago

@SepidehAlassi Yes, you are right. There is a JSON file that contains the specifics. I think we could just have several configuration files for different volumes. The rest of the logic should be generic.