dasch-swiss / knora-ui

Reusable GUI elements for Knora
https://dasch-swiss.github.io/knora-ui
7 stars 1 forks source link

style: Global stylesheet to override material style #313

Closed kilchenmann closed 5 years ago

kilchenmann commented 5 years ago

In some cases we have to override some material styles. But because the material components, as almost all angular components and modules, are built on the fly, the place to override styles has to be defined global in the app. This is an issue in case of our knora-ui modules. If someone wants to use the module, he/she has to add some lines to the main stylesheet file. This is not a good workaround. We should define a main stylesheet for our modules. The only thing an app-developer has to do, is to add something like: "node_modules/@knora/action/assets/style/action.scss" to the angular.json file of the app. Not the best solution as well, but better than add style to main.scss file. I try to use this solution with the action module at the moment. But I think we should have a solution like the material modules has. One main stylesheet to add to the app and that's it.

kilchenmann commented 5 years ago

Closed by PR #315