Fix tests in @knora/search

dasch-swiss / knora-ui

Reusable GUI elements for Knora

https://dasch-swiss.github.io/knora-ui

7 stars 1 forks source link

Fix tests in @knora/search #371

Closed flavens closed 4 years ago

flavens commented 5 years ago

Fix the tests of search module.

[x] Replace the imports from knora/core by knora/api endpoints and models
[x] Fix broken tests

The test data will come from the knora-api-js-lib now on, the needed objects already deserialized

flavens commented 4 years ago

@tobiasschweizer I need your help to fix the tests in extended-search, I do not know what replaces OntologyMetadata in knora-api-js-lib and what the signature should be.

tobiasschweizer commented 4 years ago

Ontology information (consisting of ClassDefinition and PropertyDefinition) can be obtained from https://github.com/dasch-swiss/knora-api-js-lib/blob/master/src/cache/OntologyCache.ts. Information will only be queried once from Knora.

You can get OntologiesMetadata from the OntologiesEndpoint, we do not cache it. I think the app could get it when its starts.

I can help you on Wednesday.

flavens commented 4 years ago

N.B. Extended search tests have been excluded temporarily, they required new methods and test data from knora-api-lib.