dasch-swiss / knora-ui

Reusable GUI elements for Knora
https://dasch-swiss.github.io/knora-ui
7 stars 1 forks source link

Clean up PRs and old branches #384

Closed kilchenmann closed 4 years ago

kilchenmann commented 4 years ago

As we moved the api request services to an own repo (@knora/api), we can clean up PRs, branches and probably old issues belongs to knora api services.

flavens commented 4 years ago

@kilchenmann some branches and issues have been closed/merged, what about wip/126-search-subscriptions because #381 has been merged?

kilchenmann commented 4 years ago

@flavens wip/126-search-subscriptions was closed manually and not by #381. We decided together to close the PR if I remember correctly. I thought we fixed the subscription issue by implementing the material paging module.

flavens commented 4 years ago

@tobiasschweizer what should we do with the branches:

keep them or close them?

tobiasschweizer commented 4 years ago

I think you can close wip/126-search-subscriptions, but the date issue was related to the date pipe right? So this will reoccur if you still want to use it.

flavens commented 4 years ago

@tobiasschweizer if this is ok for you, I will also close the branch fix/issue-132-wrong-dates because there is no commit, no changes at all in it...

tobiasschweizer commented 4 years ago

ok