search

dasch-swiss / knora-ui

Reusable GUI elements for Knora
https://dasch-swiss.github.io/knora-ui
7 stars 1 forks source link

Add missing property name in NewProperty declaration #407

Closed kilchenmann closed 4 years ago

kilchenmann commented 4 years ago

The property name was missing in the declaration of NewProperty.

We used the label as name and this was wrong and is fixed now.

kilchenmann commented 4 years ago

@flavens if you want to test it (for the review), you can use the latest version of Knora-app/wip/simple-ontology-creator and add it with yalc.

flavens commented 4 years ago

@flavens if you want to test it (for the review), you can use the latest version of Knora-app/wip/simple-ontology-creator and add it with yalc.

ok I will do it this afternoon!

flavens commented 4 years ago

@kilchenmann is this only a change in the code without any impact on the UI or is there a change in the UI as well? If yes, where?

kilchenmann commented 4 years ago

It is only a small modification in the code and has no direct effect on the GUI. I see, my comment above is a bit confusing.

kilchenmann commented 4 years ago

The newProperty declaration is now similar to newResourceClass and has the name property inside.

kilchenmann commented 4 years ago

Thanks @flavens