search

dasch-swiss / sipi

Simple Image Presentation Interface
https://sipi.io
GNU Affero General Public License v3.0
32 stars 8 forks source link

fix: update ijg jpeg lib to v9f, partially fixes DEV-3474 #449

Closed siers closed 2 months ago

siers commented 2 months ago

~As far as I understand, the core of the issue is that the ijg library used not to correctly recognize when the 4 channel colorspace is actually YCCA, which is likely (but I can't say with 100% certainty) fixed in v9e: https://github.com/libjpeg-turbo/ijg/commit/ff9491d4e0a06542ae82367183e4548664705d80#diff-71516311e7ecc262ab53731fc7ec0ea1c6d50ff9367bdea67804f9af5c9015e5L165-R180~

~I discovered where the bug lies after checking that the values of a image of just cyan (100%, 0%, 0%, 0%) are 0, 255, 255, 255, so it could not have been the fault of the image profile convertor (LittleCMS, in this case. In addition, I tried setting all the parameters for LCMS manually and tested it with a byte array, which was all correct.)~

~Knowing the root cause, additional reports of such problems can be found, because this feature space is dependent on vendor markers and likely not tested as extensively.~

~With the ijg lib updated to v9f, the original file attached in the issue is getting converted correctly, although files converted with imagemagick still remain black.~

linear[bot] commented 2 months ago

DEV-3474 Images from LHTT Project have a black background

codecov-commenter commented 2 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 22.5%. Comparing base (2a30eee) to head (5fd53d4).

Additional details and impacted files [see 4 files with indirect coverage changes](https://app.codecov.io/gh/dasch-swiss/sipi/pull/449/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dasch-swiss)