search

dasch / avro_turf

A library that makes it easier to use the Avro serialization format from Ruby.
MIT License
167 stars 80 forks source link

Set `idempotent: true` by default #199

Closed akihiro17 closed 1 year ago

akihiro17 commented 1 year ago

related to https://github.com/dasch/avro_turf/pull/198

I'd like to pass Excon options(e.g. idempotent: true) to the CachedConfluentSchemaRegistry methods so that the Excon can retry the failed requests automatically.

In this commit, I set idempotent: true for every request to the SchemeRegistry.

By the way, I'm not sure whether it is safe for us to set idempotent: true to requests for the SchemaRegistry. ref. https://docs.confluent.io/platform/current/schema-registry/develop/api.html

akihiro17 commented 1 year ago

updated the changelog.

https://github.com/dasch/avro_turf/pull/199/commits/90b42543b2b5ad8554a5e3a5c6acef8a35686c9f