daschu / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #5

Open ad3429 opened 6 years ago

ad3429 commented 6 years ago

Summary Grade: Satisfactory

Good job! Your files are organized nicely, and you did a great job of following the client specification -- this is an important skill to have as a developer and you seem to understand that. Moreover, you generally followed good code practice, so make sure to keep that up!

I have made some comments in your code to take note of. First off, make sure to comment the main parts of your code (both your HTML and CSS) in future projects. This will greatly help your development flow, especially as your projects get larger and more complex. Here is a quick refresher on commenting in HTML and CSS, respectively:

html_comment css comment

Next off, rather than giving your brushes, frames and paint elements classes, you should instead assign them ID's since they are unique, individual elements. You usually use class when you want to give a group of elements the same styling. Here is a great resource that explains the difference between class and ID:

https://css-tricks.com/the-difference-between-id-and-class/

Good job overall! As a further challenge, try using css to design your webpage even further! You did a great job in following the client specification, but for your own practice you should see how creative you can get by taking the design/styling of your site to the next level (for example, you can try experimenting with background colors on your other divs).

daschu commented 6 years ago

You write: "I have made some comments in your code to take note of." Where can I find them. I had a look to my uploaded files and couldn't find any comment

ad3429 commented 6 years ago

If you click "Issues" at the top you should be able to find them all there