search

dascritch / cpu-audio

An audio WebComponent to provide timecoded links and other features to an audio tag
https://dascritch.github.io/cpu-audio/
GNU Lesser General Public License v3.0
24 stars 2 forks source link

Regression on cpu-controller mode, dynamically interpret attributes changes #128

Closed dascritch closed 3 years ago

dascritch commented 3 years ago

When a CPU-Controller has a mode="button", and a player any upper mode, the Controller wrongly takes the player mode at play.

dascritch commented 3 years ago

And panels are shown :(

dascritch commented 3 years ago

Regression only on gh-pages, because on cpu-controller insertion in _includes/footer.html : 

    document.addEventListener('DOMContentLoaded', () => {
        if (!document.querySelector('cpu-audio')) {
            return;
        }
        const controller = document.createElement('cpu-controller');
        controller.setAttribute('mode', 'button');
        document.querySelector('h1').prepend(controller);
    });
dascritch commented 3 years ago

Too many problems with this gh-pages theme

dascritch commented 3 years ago

We may need to change "on the fly" webcomponent redenring if mode or hide are dynamically changing