Make CpuAudio and CpuController tag names parametrables

dascritch / cpu-audio

An audio WebComponent to provide timecoded links and other features to an audio tag

https://dascritch.github.io/cpu-audio/

GNU Lesser General Public License v3.0

24 stars 2 forks source link

Make CpuAudio and CpuController tag names parametrables #187

Closed dascritch closed 1 year ago

dascritch commented 1 year ago

As for #186 , it won't be asked by users, but it help to remove magic constants. It may inflate a bit the source code.

[ ] implement in code
[ ] document
[ ] add in live_config

dascritch commented 1 year ago

in utils , we declare

export const CpuAudioTagName = 'CPU-AUDIO';
export const CpuControllerTagName = 'CPU-CONTROLLER';
[…]
export const selectorAudioInComponent = 'cpu-audio audio';

Instead, add to document.CPU for playerTag and controllerTag.

dascritch commented 1 year ago

No, very wrong idea. Doable, but those are our signature tags