search

dasec / fishy

Toolkit for Filesystem based Data Hiding Techniques.
MIT License
36 stars 1 forks source link

NTFS: Fileslack, mftslack, bad cluster should not open filesystem streams itself #29

Closed importantchoice closed 6 years ago

importantchoice commented 6 years ago

All three named hiding techniques open their filesystem streams by themself. This violates the principles, we defined earlier. The cli already passes an open filesytem stream to the do_ function. So, they should use it.

rkgk04 commented 6 years ago

passed filestream in the wrapper and adjusted code in the respective modules, issue itself can be closed test modules need to be adjusted

importantchoice commented 6 years ago

I think failing tests are not a thing, that we should leave open in master. As it relates to this issue, I suggest keeping it open, until those failing tests are fixed.