search

dash-docs-el / helm-dash

Browse Dash docsets inside emacs
511 stars 59 forks source link

Candidates-process is called every keypress. #125

Closed kidd closed 8 years ago

kidd commented 8 years ago

In db04dd562526163131, we introduced a bug that searched the db's just on init, not following minimal-length or recalculating results. This commit fixes it.

Fixes #124

areina commented 8 years ago

Hey @kidd, I'm trying this PR but seems like it doesn't solve the issue. The db is called only on init.

areina commented 8 years ago

Ok, I think I found it. :volatile option is missing in helm-dash-build-source function. Also, I think that function is wrong because it's using helm-build-async-source and I would say that method expects a function in candidates-process that returns a process and our function returns a list. We should use helm-build-sync-source or change our internal functions.

kidd commented 8 years ago

I think :volatile doesn't affect anything on async sources, but I will check it again. Regarding the process vs list, I think you're right, but until now we had a function 'helm-dash-search, and was working ok.

It's working fine here using the last helm-core and helm versions.

areina commented 8 years ago

Right, :volatile is for sync sources. I will try to update helm-core&helm and see if it works well.

By the way, to be coherent in our code, I think we should use helm-build-sync-source and volatile option.

areina commented 8 years ago

Sorry but I'm testing it with last helm/helm-core versions and it isn't working.

areina commented 8 years ago

Hey @kidd, please, could you confirm this is working for you? Thx!

kidd commented 8 years ago

Works fine on my machine. merging it. It's super weird that without this last commit it was also working perfect here... Mysteries...