search

dash-docs-el / helm-dash

Browse Dash docsets inside emacs
510 stars 59 forks source link

Allow for docset.dsidx sqlite database #177

Closed vspinu closed 5 years ago

vspinu commented 5 years ago

The javadocset tooling https://github.com/william8th/javadocset generates docset.dsidx instead of docSet.dsidx. From this I infer that both dash and zealdocs understand both names.

Throwing an error if file doesn't exist because otherwise sqlite creates a 0 size database which results in confusing errors.

kidd commented 5 years ago

Hi @vspinu, Looks like zeal only uses the camelcase string: https://github.com/zealdocs/zeal/search?q=docset.dsidx&unscoped_q=docset.dsidx. Given that the repo you linked is not very spread, maybe a PR there producing a camelcase file would render a better net benefit.

WDYT?

vspinu commented 5 years ago

There is a PR there for this since August (william8th/javadocset#2) but no response so far from the author.

william8th commented 5 years ago

Apologies for the late reply @vspinu. I agree with @kidd that it's better to have this issue resolved in my repo (william8th/javadocset) than in areina/helm-dash. I'm just doing some manual testing on it and if everything works fine, I think it's okay to close this PR and let's keep the camel case!

kidd commented 5 years ago

Thank you very much @william8th ! Closing this