search

dash-docs-el / helm-dash

Browse Dash docsets inside emacs
510 stars 59 forks source link

Windows file fixes #181

Closed jeeger closed 5 years ago

jeeger commented 5 years ago

Made tar extraction work on windows, along with some added niceties like filename transformation and detection of overlong filenames.

kidd commented 5 years ago

looks good! Thanks for working on this long standing issue @jeeger.

I'm gonna find some time to try the branch in linux and merge it asap.

jeeger commented 5 years ago

Please do! Also someone who is a Windows user can try the Haskell fileset to check whether the "long filename" warning works correctly.

kidd commented 5 years ago

Tried briefly on linux and works. In!

Thanks for your contribution

gilbertw1 commented 5 years ago

FYI, I fixed a few minor issues here in my running fork: https://github.com/gilbertw1/dash-docs/commit/8b7f336b76631fd7d1e7203ba7c869bcea585ebd

jeeger commented 5 years ago

That should probably be merged as well, as the code I've written for the overlong filename warning was pretty much off-the-cuff :confused: