search

dash-docs-el / helm-dash

Browse Dash docsets inside emacs
510 stars 59 forks source link

Why is helm-dash-completing-read-func used? #51

Closed alanpearce closed 9 years ago

alanpearce commented 10 years ago

I'm a bit curious about the use of helm-dash-completing-read-func. Is there any reason it's being used in a helm-specific package?

When I asked helm-dash to install a docset, I wasn't expecting an ido prompt. Now I could quite happily add helm-comp-read to the options for helm-dash-completing-read-func and perhaps make it the default, but on second thought, it seems a little weird to have the configuration at all here.

kidd commented 10 years ago

there's no reason to have ido there.... it just worked fine at that time and we left it as it was...

definately, using helm for everything makes more sense. no need for options at all.

areina commented 10 years ago

Hi @alanpearce , you're right. We'll try to change it in next days. Thanks for your feedback.

alanpearce commented 10 years ago

Cool, I was going to do it myself, but I got a bit busy with other things.

kidd commented 10 years ago

whoever writes it first gets a candy!