Don't require helm-mode

dash-docs-el / helm-dash

Browse Dash docsets inside emacs

511 stars 59 forks source link

Don't require helm-mode #61

Closed simonthum closed 9 years ago

simonthum commented 9 years ago

Hi,

on my win32 emacs I only get helm-dash to work (more precisely, list doclets) when

helm-comp-read-case-fold-search

is non-nil, which is defined in helm-mode. AFAIK helm-mode is considered optional, in general.

purcell commented 9 years ago

True. Probably helm-dash should just call completing-read, and then if helm-mode is active, that will automatically result in helm-comp-read getting called. That said, in #68 I've added the missing (require 'helm-mode), so that the file byte-compiles cleanly.

simonthum commented 9 years ago

Then as long as that doesn't actually activate help-mode I'm fine with closing the issue. Thanks!

purcell commented 9 years ago

I've fixed this in #69 so that no reference to helm-mode is made, but if helm-mode is enabled, then the completion will be done using helm.

simonthum commented 9 years ago

Cool!