dash-docs-el / helm-dash

Browse Dash docsets inside emacs
510 stars 59 forks source link

helm-dash can't open result entry. #62

Closed stardiviner closed 9 years ago

stardiviner commented 9 years ago

I have Emacs version 25.0.50.2 And use the latest helm-dash from el-get.

And have this configuration.

(require 'helm-dash)

(setq helm-dash-docsets-path (expand-file-name "~/.docsets")
      helm-dash-min-length 3
      ;; helm-dash-completing-read-func 'completing-read ; 'completing-read, 'ido-completing-read
      helm-dash-browser-func 'browse-url ; 'browse-url, 'eww
      ;; helm-dash-connections
      helm-dash-common-docsets '("Ruby" "Ruby on Rails"
                                 "Python 3"
                                 "HTML" "CSS" "JavaScript" "CoffeeScript"
                                 "Common_Lisp" "Clojure"
                                 "C" "Go"
                                 "SQLite" "MySQL" "Redis" "MongoDB"
                                 "Qt"
                                 "Vagrant" "Nginx"
                                 "Android"
                                 "RubyMotion" "AngularJS"
                                 )
      ;; helm-dash-docsets
      )

And when I press Enter on result entry Ruby Kernel.autoload. Then this error raised.

(wrong-type-argument stringp ("Ruby" ("clm" "Kernel.autoload" "Kernel.html#method-i-autoload")))
  try-completion(("Ruby" ("clm" "Kernel.autoload" "Kernel.html#method-i-autoload")) nil nil)
  helm-confirm-and-exit-minibuffer()
  funcall-interactively(helm-confirm-and-exit-minibuffer)
  call-interactively(helm-confirm-and-exit-minibuffer nil nil)
  command-execute(helm-confirm-and-exit-minibuffer)
  read-from-minibuffer("pattern: " nil (keymap (return . helm-confirm-and-exit-minibuffer) (tab . helm-select-action) (f13 lambda nil (interactive) (helm-select-nth-action 12)) (f12 lambda nil (interactive) (helm-select-nth-action 11)) (f11 lambda nil (interactive) (helm-select-nth-action 10)) (f10 lambda nil (interactive) (helm-select-nth-action 9)) (f9 lambda nil (interactive) (helm-select-nth-action 8)) (f8 lambda nil (interactive) (helm-select-nth-action 7)) (f7 lambda nil (interactive) (helm-select-nth-action 6)) (f6 lambda nil (interactive) (helm-select-nth-action 5)) (f5 lambda nil (interactive) (helm-select-nth-action 4)) (f4 lambda nil (interactive) (helm-select-nth-action 3)) (f3 lambda nil (interactive) (helm-select-nth-action 2)) (f2 lambda nil (interactive) (helm-select-nth-action 1)) (menu-bar keymap (help-menu keymap (describe keymap (describe-mode . helm-help)))) (help keymap (109 . helm-help)) (f1 lambda nil (interactive) (helm-select-nth-action 0)) (8 keymap (109 . helm-help) (104 . undefined) (8 . undefined) (4 . helm-debug-output)) (20 . helm-toggle-resplit-and-swap-windows) (C-tab . undefined) (triple-mouse-3 . ignore) (double-mouse-3 . ignore) (mouse-3 . ignore) (drag-mouse-3 . ignore) (down-mouse-3 . ignore) (triple-mouse-2 . ignore) (double-mouse-2 . ignore) (mouse-2 . ignore) (drag-mouse-2 . ignore) (down-mouse-2 . ignore) (triple-mouse-1 . ignore) (double-mouse-1 . ignore) (mouse-1 . ignore) (drag-mouse-1 . ignore) (down-mouse-1 . ignore) (67108897 . helm-toggle-suspend-update) (3 keymap (21 . helm-force-update) (6 . helm-follow-mode) (9 . helm-copy-to-buffer) (11 . helm-kill-selection-and-quit) (25 . helm-yank-selection) (4 . helm-delete-current-selection) (45 . helm-swap-windows)) (67108987 . helm-enlarge-window) (67108989 . helm-narrow-window) (19 . undefined) (18 . undefined) (23 . helm-yank-text-at-point) (24 keymap (2 . helm-resume-list-buffers-after-quit) (98 . helm-resume-previous-session-after-quit) (6 . helm-quit-and-find-file)) (11 . helm-delete-minibuffer-contents) (67108896 . helm-toggle-visible-mark) (0 . helm-toggle-visible-mark) (C-M-up . helm-scroll-other-window-down) (C-M-down . helm-scroll-other-window) (M-prior . helm-scroll-other-window-down) ...) nil nil nil t)
  helm-read-pattern-maybe(nil nil nil nil nil nil nil)
  helm-internal((((name . "Dash") (volatile) (delayed) (requires-pattern . 3) (candidates-process . helm-dash-search) (action-transformer . helm-dash-actions))) nil nil nil nil "*helm-dash*" nil nil nil)
  apply(helm-internal ((((name . "Dash") (volatile) (delayed) (requires-pattern . 3) (candidates-process . helm-dash-search) (action-transformer . helm-dash-actions))) nil nil nil nil "*helm-dash*" nil nil nil))
  helm((((name . "Dash") (volatile) (delayed) (requires-pattern . 3) (candidates-process . helm-dash-search) (action-transformer . helm-dash-actions))) nil nil nil nil "*helm-dash*" nil nil nil)
  apply(helm ((((name . "Dash") (volatile) (delayed) (requires-pattern . 3) (candidates-process . helm-dash-search) (action-transformer . helm-dash-actions))) nil nil nil nil "*helm-dash*" nil nil nil))
  helm(:sources (((name . "Dash") (volatile) (delayed) (requires-pattern . 3) (candidates-process . helm-dash-search) (action-transformer . helm-dash-actions))) :buffer "*helm-dash*" :input nil)
  helm-dash-at-point()
  funcall-interactively(helm-dash-at-point)
  call-interactively(helm-dash-at-point nil nil)
  command-execute(helm-dash-at-point)
areina commented 9 years ago

Hi @stardiviner, we're trying to reproduce your error locally. I'll reply you soon

kidd commented 9 years ago

FYI: I couldn't reproduce it in 24.

areina commented 9 years ago

me neither in emacs 25.0.50.1

Could be something related with helm? @stardiviner could you confirm that you're using latest versions of helm and helm-dash? thanks

stardiviner commented 9 years ago

I found the reason.

  (define-key helm-map (kbd "<RET>") 'helm-maybe-exit-minibuffer)

  ;; NOTE: this cause helm-dash open menu candidate error.
  ;; (define-key helm-map (kbd "<return>") 'helm-confirm-and-exit-minibuffer)