search

dash-docs-el / helm-dash

Browse Dash docsets inside emacs
510 stars 59 forks source link

Allow full HTTP links #65

Closed otsaloma closed 9 years ago

otsaloma commented 9 years ago

helm-dash seems to work with local HTML files and file:// URLs. It would be useful if the "path" could be a full http(s):// link. This way I could avoid trying scrape some gigantic web pages, just download an index page, parse that and construct full HTTP URLs in the database file. Dash allows this too ("Alternatively, Dash also supports http:// URL entries.").

Maybe something like

(if (string-match-p "^https?://" path) 
    path
  ...)

in helm-dash-result-url? Do you want a pull request?

kidd commented 9 years ago

A pull request is fine. Otherwise we'll try to implement it soon. Thanks for the report

kidd commented 9 years ago

Do you have any docset with that format to test it ?

otsaloma commented 9 years ago

Pull request: https://github.com/areina/helm-dash/pull/66 For testing: https://dl.dropboxusercontent.com/u/39625783/Python.docset.tar.xz