search

dash-docs-el / helm-dash

Browse Dash docsets inside emacs
510 stars 59 forks source link

Work on OS X, alongside the original Dash (also: various fixes) #68

Closed purcell closed 9 years ago

purcell commented 9 years ago

The docset paths on OS X are different, and the docsets installed by Dash itself are nested in subfolders. So this PR contains fixes which ensure that helm-dash works for users on OS X who have Dash installed.

The only caution is that OS X users with the original Dash installed might find that installing docsets from helm-dash confuses (or even breaks) Dash. I haven't tried that out.

Disclaimer: I haven't tested this on a non-OS X system, but I haven't made any changes which I would expect to break things elsewhere. :-)

kidd commented 9 years ago

Hi! Thanks for the patches! I see there's a test failing https://travis-ci.org/areina/helm-dash/builds/44382874 . According to that, it's just complaining about the removed h-d-starts-with . Could you give it a look (removing the test is fine if it's really useless ). If not, we'll take a look and fix it as soon as we can (weekend probably).

purcell commented 9 years ago

Sorry, my mistake -- just pushed a fix.

purcell commented 9 years ago

Hmm, still failing. I'll get cask and figure this out locally, then let you know when it's fixed. :-)

purcell commented 9 years ago

There we go -- much better!

areina commented 9 years ago

Hey, awesome @purcell. I'm going to try it in linux and will merge if everything is ok. Thanks a lot for contributing.

purcell commented 9 years ago

Yeah, just ping me if you see anything that needs fixing up.

areina commented 9 years ago

it works perfectly, merging

purcell commented 9 years ago

Great! Thanks for your patience.