dasha3412 / pe

0 stars 0 forks source link

Too much input validation for names #10

Open dasha3412 opened 4 days ago

dasha3412 commented 4 days ago

Names are not allowed to contain characters like / (names including S/O) or ', which many names might contain. This would prevent many users from using the program, as they cannot enter themselves or other contacts correctly into the system

Enter edit 1 n/Roy S/O JJJJ

Screenshot 2024-11-15 at 5.39.27 PM.png

nus-se-script commented 10 hours ago

[IMPORTANT!: Please do not edit or reply to this comment using the GitHub UI. You can respond to it using CATcher during the next phase of the PE]

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unable to add names with the phrase "S/O" or with '

In the screenshot, I tried to add the person "Bala S/O Vignesh" into the address book. However this was not allowed as "/" is a prohibited character in the name field.

image.png

This is an issue as the phrase "S/O" is extremely common in Indian names and I will be unable to add names containing this phrase into the address book. One way to fix it is to only allow the "/" when it is part of the phrase "S/O" or "D/O" , or completely allow the / altogether. I am also unable to add names that contain ', such as "Jerome D' Ambrosio".

image.png


[original: nus-cs2103-AY2425S1/pe-interim#3453] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Hi,

We believe that this bug does not particularly affect the functionality of the application. In fact, we received this bug during our PE-Dry-Run, but chose not to put it in the enhancements, as we believed that it was a rather minor issue. S/O stands for son of, which can simply be typed in as part of the name. D/O stands for daughter of, which can also be typed.

However, we overlooked the fact that some names in cultures have apostrophes. However, we believe it is rather uncommon in a Singaporean context. Moreover, users can simply not put the apostrophe in the name.

We also believe that this bug is not in scope. The handling of names in NetBook is carried over from the original product AB3, and as such, is not particularly related to the features that we have implemented.

We do believe that this does cause a minor inconvenience to our users. As such, we believe that this should be of low severity, and not be in scope

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your reason]


## :question: Issue response Team chose [`response.NotInScope`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue type Team chose [`type.FunctionalityBug`] Originally [`type.FeatureFlaw`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your reason]