search

dashbitco / broadway

Concurrent and multi-stage data ingestion and data processing with Elixir
https://elixir-broadway.org
Apache License 2.0
2.43k stars 161 forks source link

Broadway v1.0.4 Broadway.NoopAcknowledger returns NoopAcknowledger instead of Broadway.NoopAcknowledger #315

Closed seantanly closed 1 year ago

seantanly commented 1 year ago

Looks like Broadway v1.0.4 has an issue with the noop_acknoledger which returns NoopAcknowledger instead of Broadway.NoopAcknowledger for acknowledger in %Broadway.Message{}.

https://github.com/dashbitco/broadway/blob/7c93cdbe9ef120d8f178d9d121bc9f7b127579d9/lib/broadway/noop_acknowledger.ex#L16

seantanly commented 1 year ago

Thank you for the speedy fix!