search

dashbitco / broadway_cloud_pub_sub

A Broadway producer for Google Cloud Pub/Sub
Apache License 2.0
70 stars 24 forks source link

Bump goth to ~> 1.0 #21

Closed wojtekmach closed 5 years ago

wojtekmach commented 5 years ago

Since there's a stable release we should test against it and update code and docs accordingly.

mcrumm commented 5 years ago

Goth 1.x should work fine, but when we upgrade, we'll probably want to pin poison < 4.0 because of googleapis/elixir-google-api#1232

Otherwise I'm afraid we'll get a lot of issues around errors caused by version mismatches.

wojtekmach commented 5 years ago

Thanks for the heads-up! Looks like recent gax has the following requirement on poison:

{:poison, ">= 1.0.0 and < 4.0.0"},

so we may already be good but I'll definitely double-check.

mcrumm commented 5 years ago

Oh, that's right. They fixed the dependency, but not the compatibility with Poison v4, as of 0.1.3.

vans163 commented 5 years ago

Just pumped into this issue on latest goth 1.1.0, had to set poison under <4.0.0