Replace :token_module opt with :token_generator

dashbitco / broadway_cloud_pub_sub

A Broadway producer for Google Cloud Pub/Sub

Apache License 2.0

70 stars 24 forks source link

Replace :token_module opt with :token_generator #29

Closed mcrumm closed 5 years ago

mcrumm commented 5 years ago

Changes:

Adds the :token_generator option to allow passing an MFArgs tuple that should return {:ok, String.t()} | :error
Soft-deprecates the :token_module option
Builds a token generator MFA from the :scope option if neither :token_generator nor :token_module are specified.
Hides the BroadwayCloudPubSub.Token behaviour

Closes #27

josevalim commented 5 years ago

@mcrumm given we are pre 1.0, I think we can just go ahead and remove token_module, what do you think? And we would make it clear on a new release that it has backcwards incompatible changes.

mcrumm commented 5 years ago

:+1: I'm good with that. And the only consumers of this package that I know of aren't using a custom token_module, anyway.

Correct me if I'm wrong @sbennett33 @znorris