Add support for configuring the acking behaviour

dashbitco / broadway_cloud_pub_sub

A Broadway producer for Google Cloud Pub/Sub

Apache License 2.0

70 stars 24 forks source link

Add support for configuring the acking behaviour #36

Closed rockneurotiko closed 5 years ago

rockneurotiko commented 5 years ago

Related to plataformatec/broadway#108, plataformatec/broadway#109 and plataformatec/broadway_rabbitmq#42 (where I got my inspiration for this PR)

I added the basic operations,

:ack, current behaviour for success messages
:ignore, current behaviour for failed messages, and set as the default for them
{:no_ack, integer} Maybe it's better :set_deadline or :deadline ?
:no_ack, a shortcut for {:no_ack, 0}, it probably can be removed

josevalim commented 5 years ago

This looks really good, thank you @rockneurotiko!

What do you think @mcrumm?

rockneurotiko commented 5 years ago

Thanks @josevalim and @mcrumm I applied the suggested changes 😄

josevalim commented 5 years ago

We are discussing supporting {mod, fun, args} in these callbacks as well. If we do so, we should probably add the same feature here, so your opinion is welcome: https://github.com/plataformatec/broadway_sqs/pull/35