Closed rockneurotiko closed 5 years ago
This looks really good, thank you @rockneurotiko!
What do you think @mcrumm?
Thanks @josevalim and @mcrumm I applied the suggested changes 😄
We are discussing supporting {mod, fun, args}
in these callbacks as well. If we do so, we should probably add the same feature here, so your opinion is welcome: https://github.com/plataformatec/broadway_sqs/pull/35
Related to plataformatec/broadway#108, plataformatec/broadway#109 and plataformatec/broadway_rabbitmq#42 (where I got my inspiration for this PR)
I added the basic operations,
:ack
, current behaviour for success messages:ignore
, current behaviour for failed messages, and set as the default for them{:no_ack, integer}
Maybe it's better:set_deadline
or:deadline
?:no_ack
, a shortcut for{:no_ack, 0}
, it probably can be removed