Closed monkybrain closed 4 years ago
You need to change the test that checks that the maximum ackIds is being used 😄
@rockneurotiko thanks! 🤦Sorted!
Nice, quick review! Thanks for a great lib guys :tada:
@mcrumm Would you mind creating a release for this change? We still use a fork with the fix since it's not updated on hex.pm :pray: :revolving_hearts:
Hi @m0ar, thanks for the ping - done! :)
@mcrumm :cupcake:
We found that processing large batches would result in acknowledgement requests failing due to exceeded payload size (
Request payload size exceeds the limit: 524288 bytes
).The problem seems to be the assumption that ack ids have a maximum size of 164 bytes. Perhaps Google changed this recently because we found that our ack ids were 184 bytes.
Our solution was simply to update the formula for calculating a safe limit and reduce the constant
max_ack_ids_per_request
to2500
. This seems to have solved the problem.