dashbitco / broadway_cloud_pub_sub

A Broadway producer for Google Cloud Pub/Sub
Apache License 2.0
70 stars 24 forks source link

Remove sensitive details from error log messages #57

Closed darrenclark closed 3 years ago

darrenclark commented 3 years ago

I saw the Authorization header inadvertently gets logged in errors (see screenshot below)

This PR drops the :__client__ field from the %Tesla.Env{} before inspect-ing it, so that the Authorization header is no longer logged

darrenclark commented 3 years ago

@mcrumm you're welcome!

mcrumm commented 3 years ago

Thanks! <3