Add middleware option and fix should_retry?/1

dashbitco / broadway_cloud_pub_sub

A Broadway producer for Google Cloud Pub/Sub

Apache License 2.0

70 stars 24 forks source link

Add middleware option and fix should_retry?/1 #60

Closed wronfim closed 3 years ago

wronfim commented 3 years ago

Issue: #59

Custom Tesla middleware can be passed via :middleware option
Retry middleware still configurable via :retry
should_retry?/1 checks the status of :ok responses as well
Reduced the test retry delay opt down to 1, just to make tests faster

@wojtekmach Let me know if you liked the idea of having a :middleware option. That was the cleaner solution I could think to solve your hard coded middleware example.

SophisticaSean commented 3 years ago

lgtm

wojtekmach commented 3 years ago

Thank you!

skbolton commented 3 years ago

@wojtekmach any idea on when a release is going to happen with these changes?

wojtekmach commented 3 years ago

v0.6.3 is out!