dashbitco / broadway_cloud_pub_sub

A Broadway producer for Google Cloud Pub/Sub
Apache License 2.0
70 stars 24 forks source link

Fix crash with empty response on pull call #68

Closed rockneurotiko closed 2 years ago

rockneurotiko commented 2 years ago

This PR is to fix #67

The PubSub JSON api can return an empty response when there are no messages to pull, and right now the code is crashing when that happens.

josevalim commented 2 years ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

mcrumm commented 2 years ago

Thank you @rockneurotiko!! It would appear the Pub/Sub spec is not entirely accurate :)