Catches {:error, :invalid, integer()} case when receiving messages

[jekku]

What's here?

This PR is for the current version of the library.

In the current version of this library (v0.7.1), when receive_messages/3 is invoked, we sometimes receive this kind of error tuple with 3 members:

{:error, :invalid, integer}

The stacktrace from the exception thrown from the library looks like this:

FunctionClauseError: no function clause matching in BroadwayCloudPubSub.GoogleApiClient.handle_response/2
  File "lib/broadway_cloud_pub_sub/google_api_client.ex", line 146, in BroadwayCloudPubSub.GoogleApiClient.handle_response/2
  File "lib/broadway_cloud_pub_sub/google_api_client.ex", line 116, in BroadwayCloudPubSub.GoogleApiClient.receive_messages/3
  File "lib/broadway_cloud_pub_sub/producer.ex", line 240, in BroadwayCloudPubSub.Producer.handle_receive_messages/1
  File "lib/broadway/topology/producer_stage.ex", line 229, in Broadway.Topology.ProducerStage.handle_info/2
  File "lib/gen_stage.ex", line 2117, in GenStage.noreply_callback/3

What we've checked and tried

• GoogleApi.PubSub.V1.Api.Projects.pubsub_projects_subscriptions_pull/3 seems to be returning this tuple
• It leads into an HTTP request via Tesla. For some reason, even if the typespec and signatures all point to a proper {:error, Tesla.env()} tuple, there are still times where a tuple of 3 members appears
• Tried to write a unit test for this case as well, but we can't mock Tesla.Mock to return an error tuple of 3 members. Maybe we can make handle_response/2 public and test that instead?

[jekku]

Commenting some snaps with the whole stacktrace from the platform that stores our exceptions just in case it helps

[josevalim]

Thank you! It seems this bug needs to be patched upstream instead, by whatever is actually returning the invalid tuple, no? :)

[jekku]

That seems to be reasonable. Further justified by the move to Finch as well. Just wondering currently when we'll might get a release and some docs on the newer version? :)

Closing this now.

[josevalim]

Please do try it out and let us know it works, that will certainly get us closer to a new release. Thank you!