"Throughput" and "All time" counters history

[mpugach]

Hi

I have implemented a history module for the live dashboard, and it works for Phoenix and my custom metrics but does not work for BroadwayDashboard.

live_dashboard "/dashboard",
      metrics: MyMegaApp.Telemetry,
      additional_pages: [
        broadway: BroadwayDashboard
      ],
      metrics_history: {MyMegaApp.Telemetry.History, :metrics_history, []}

The MyMegaApp.Telemetry.History.metrics_history/1 contains a logger, so I can see that BroadwayDashboard does not call for history.

How can counters history be implemented in BroadwayDashboard?

Package versions:

%{
  "broadway": "1.0.0",
  "broadway_dashboard": "0.2.1",
  "broadway_rabbitmq": "0.7.0",
  "phoenix_live_dashboard": "0.5.3",
  "telemetry": "0.4.3",
  "telemetry_metrics": "0.6.0",
  "telemetry_poller": "0.5.0"
}

[josevalim]

Hi @mpugach! Good point, we don't invoke it but a PR would be appreciated to add this functionality. :)

[mpugach]

thanks for the clarification, will see what we can do, but no promises in the nearest future as well :)