search

dashbitco / broadway_dashboard

Keep track of your Broadway pipelines from Phoenix LiveDashboard
https://elixir-broadway.org/
Apache License 2.0
220 stars 17 forks source link

Create Metrics process on demand per pipeline #2

Closed philss closed 3 years ago

philss commented 3 years ago

This is a simplification of the Metrics GenServer to deal with only one Pipeline at a time. This way we don't need one server for all pipelines. We can spawn multiple servers and it's ok if they die because we can spawn again accessing the page.

philss commented 3 years ago

@josevalim this is the first part of that refactor we discussed. I left a TODO about adding the pipeline name to our telemetry events from Broadway. WDYT? I can work on a PR if you agree.

josevalim commented 3 years ago

@philss i think adding both partition and broadway_name would be good additions.

philss commented 3 years ago

@josevalim thanks! I'm gonna merge this. If there is something I'm missing, please feel free to comment and I fix in the next PR.