Closed moxley closed 1 year ago
Everything is perfect so far @moxley, thank you. It is fine to depend on latest dashboard, please let us know when this is ready to merge or if you have any other questions.
Thanks @josevalim. I resolved the remaining issue, and this is now ready to merge.
@moxley thank you! :purple_heart:
After updating from
phoenix 1.7.3
to1.7.6
, we started seeing warnings appear in the output of our tests:Here are our relevant dependencies:
phoenix 1.7.6
phoenix_live_dashboard 0.7.2
phoenix_live_view 0.18.18
broadway_dashboard 0.3.0
Since
phoenix_live_view 0.18.18
was apparently the culprit, I tried updating it to the latest version,0.19.3
. Thenphoenix_live_dashboard 0.7.2
wouldn't work with0.19.x
, so I tried upgradingphoenix_live_dashboard
to the latest, version0.8.0
. Then,broadway_dashboard
wouldn't work with that, because it only supports up to0.7.x
. It uses a now-removed API withinphoenix_live_dashboard
.Incidentally,
phoenix_profiler
has the samephoenix_live_dashboard
API issue, and I opened a PR for that as well.This PR updates
broadway_dashboard
to use the newphoenix_live_dashboard
API, but does this satisfy your versioning requirements? This PR makesbroadway_dashboard
require at leastphoenix_live_dashboard 0.8
.TODO