dashbitco / broadway_dashboard

Keep track of your Broadway pipelines from Phoenix LiveDashboard
https://elixir-broadway.org/
Apache License 2.0
220 stars 17 forks source link

Update to work with phoenix_live_dashboard 0.8 #26

Closed moxley closed 1 year ago

moxley commented 1 year ago

After updating from phoenix 1.7.3 to 1.7.6, we started seeing warnings appear in the output of our tests:

warning: Passing "connect_info" directly to connect/3 is deprecated, please pass "connect_info: ..." as an option instead
  (phoenix 1.7.6) lib/phoenix/test/channel_test.ex:329: Phoenix.ChannelTest.__connect__/4
  (phoenix_live_view 0.18.18) lib/phoenix_live_view/test/live_view_test.ex:1140: Phoenix.LiveViewTest.start_upload_client/6

Here are our relevant dependencies:

Since phoenix_live_view 0.18.18 was apparently the culprit, I tried updating it to the latest version, 0.19.3. Then phoenix_live_dashboard 0.7.2 wouldn't work with 0.19.x, so I tried upgrading phoenix_live_dashboard to the latest, version 0.8.0. Then, broadway_dashboard wouldn't work with that, because it only supports up to 0.7.x. It uses a now-removed API within phoenix_live_dashboard.

Incidentally, phoenix_profiler has the same phoenix_live_dashboard API issue, and I opened a PR for that as well.

This PR updates broadway_dashboard to use the new phoenix_live_dashboard API, but does this satisfy your versioning requirements? This PR makes broadway_dashboard require at least phoenix_live_dashboard 0.8.

TODO

josevalim commented 1 year ago

Everything is perfect so far @moxley, thank you. It is fine to depend on latest dashboard, please let us know when this is ready to merge or if you have any other questions.

moxley commented 1 year ago

Thanks @josevalim. I resolved the remaining issue, and this is now ready to merge.

philss commented 1 year ago

@moxley thank you! :purple_heart: