search

dashbitco / broadway_dashboard

Keep track of your Broadway pipelines from Phoenix LiveDashboard
https://elixir-broadway.org/
Apache License 2.0
220 stars 17 forks source link

Fixed the issue with multiple pipeline navigation #29

Closed HarisudhanRavi closed 10 months ago

HarisudhanRavi commented 10 months ago

When we have multiple broadway pipelines, the pipeline graph is not changed based on the selected pipeline menu. But works on reloading the page. The issue is with broadway_dashboard 0.4.0 and phoenix_live_dashboard 0.8.0

https://github.com/dashbitco/broadway_dashboard/assets/64002424/2b51a71f-c83a-4b2c-95ad-7c42bb08f582

But this works fine with broadway_dashboard 0.3.0 and phoenix_live_dashboard 0.7.0

This is because, in the latest version of broadway_dashboard, the method is not passed as expected with the phoenix_live_dashboard 0.8.0. So by default, phoenix_live_dashboard considers this as patch navigation. But as we don't have any handle_params, it is not navigating.

Since broadway_dashboard 0.3.0 passes redirect to phoenix_live_dashboard, it implements push_redirect(deprecated now) of live_view. Fixed this by passing navigate, as a separate attribute.

This is my first open-source contribution. Correct me on my approach to this. 🙂

philss commented 10 months ago

@HarisudhanRavi this fix is released under version 0.4.1 :)

HarisudhanRavi commented 10 months ago

Superb.. Thanks :)