dashbitco / broadway_dashboard

Keep track of your Broadway pipelines from Phoenix LiveDashboard
https://elixir-broadway.org/
Apache License 2.0
213 stars 17 forks source link

Move counters out of persistent term #3

Closed philss closed 3 years ago

philss commented 3 years ago

This PR is a refactor that changes the way we keep track of counters.

We remove the need for storing in a persistent term and instead we are now storing in the Metrics process, and also we pass to our Telemetry handler. Check the module Counters for details about the implementation.

With this change we had to swap the strategy of "pulling" the counters data (in the page process) to a "push" of topology workload from the Metrics process to our listeners (the page processes). This simplifies a lot the build of our graphs. :)