Closed oliveigah closed 1 year ago
Applied the proposed changes @josevalim!
prepare_for_start
callback instead of producer initializationTests are failing, can you please take a look? The linting one is quite old, so feel free to bump the Elixir version to make the formatter happier.
Tests are failing, can you please take a look?
Sure! I've tested everything locally and everything passed.
Gonna try to reproduce it. Maybe it is flaky somehow.
@josevalim, I could not reproduce the integration test problem neither locally or on CI.
But my guess is that using the same topic/group might have impacted in some way, also I increased the waiting time of the integration test, since on the failed run we missed only 1 message (999 expected 1000).
So in summary the changes were:
:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:
Context: https://github.com/dashbitco/broadway_kafka/issues/132
First attempt to solve the related issue. Let me know what you think! :smile:
Some considerations:
init/1
callback implemented by the client because I need it there in order to return the proper child_spec on the new added callback. Is this difference ok?shared_client
isfalse
the clients are being started under brod's supervisor but when it istrue
it is started under broadway supervision tree. Is that ok? I had a tricky bug because of this difference. (left a comment on the code about it)