search

dashbitco / broadway_kafka

A Broadway connector for Kafka
233 stars 53 forks source link

`brod` supports sasl credentials from file #135

Closed rewritten closed 10 months ago

rewritten commented 10 months ago

Hi folks! This PR adds support for file-based sasl credentials. From brod readme (https://github.com/kafka4beam/brod/blob/master/README.md?plain=1#L425-L428) (emphasis mine):

brod supports SASL PLAIN, SCRAM-SHA-256 and SCRAM-SHA-512 authentication mechanisms out of the box. To use it, add {sasl, {Mechanism, Username, Password}} or {sasl, {Mechanism, File}} to client config. Where Mechanism is plain | scram_sha_256 | scram_sha_512, and File is the path to a text file which contains two lines, first line for username and second line for password

rewritten commented 10 months ago

I'll squash commits before merging if the PR is accepted, since we are pointing to my branch HEAD in our systems at the moment.

josevalim commented 10 months ago

@rewritten please update the tests too :)

josevalim commented 10 months ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

Neustradamus commented 10 months ago

@rewritten: Nice!

Linked to: