dashbitco / broadway_kafka

A Broadway connector for Kafka
232 stars 53 forks source link

Fix errors caught by Dialyzer #141

Closed Stratus3D closed 5 months ago

Stratus3D commented 5 months ago

It doesn't look like Dialyzer is getting run for this project.

Below are the fixes for the errors reported by Dialyzer:

lib/broadway_kafka/brod_client.ex:83:guard_fail
The guard clause:

when _ :: Keyword.t() === nil

can never succeed.

________________________________________________________________________________
lib/broadway_kafka/brod_client.ex:114:guard_fail
The guard clause:

when _ :: pid() === nil

can never succeed.

________________________________________________________________________________
lib/broadway_kafka/kafka_client.ex:54:unknown_type
Unknown type: :brod.group_coordinator/0.
________________________________________________________________________________
done (warnings were emitted)
Halting VM with exit status 2
josevalim commented 5 months ago

:green_heart: :blue_heart: :purple_heart: :yellow_heart: :heart:

Stratus3D commented 5 months ago

Thanks @josevalim !