dashbitco / broadway_rabbitmq

A Broadway producer for RabbitMQ
193 stars 42 forks source link

Fixes #95, Add dead letter example #100

Closed lpender closed 3 years ago

lpender commented 3 years ago

This is adapted and generalized from working code but has not been tested in its adapted version. Please check for errors if possible. If not I'm sure we'll hear about them from the community :)

Not sure if this is the best place for it but it seemed like it due to the recent mention of dead letter exchanges

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 1806f2d4dcd1ef336edbf318c0f5325c7de7fffb-PR-100


Totals Coverage Status
Change from base Build 5f48634eaaa814e2339d491e2c6579510bde80f5: 0.0%
Covered Lines: 133
Relevant Lines: 175

💛 - Coveralls
josevalim commented 3 years ago

@whatyouhide if you can do a double check it will be very appreciated! :heart:

whatyouhide commented 3 years ago

@lpender I took the liberty to go ahead and commit most of your code plus the fixes we discussed directly. Thanks a lot for the contribution! 💟

lpender commented 3 years ago

ok thank you!