coveralls
commented
3 years ago Pull Request Test Coverage Report for Build 8c6547cd59f8b74e906f2965e0e8c163bf6873c7-PR-87
- 6 of 7 (85.71%) changed or added relevant lines in 2 files are covered.
- 1 unchanged line in 1 file lost coverage.
- Overall coverage increased (+0.4%) to 76.0%
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
|---|---|---|---|---|---|
| lib/broadway_rabbitmq/amqp_client.ex | 0 | 1 | 0.0% | ||
| <!-- | Total: | 6 | 7 | 85.71% | --> |
| Files with Coverage Reduction | New Missed Lines | % | ||
|---|---|---|---|---|
| lib/broadway_rabbitmq/amqp_client.ex | 1 | 30.56% | ||
| <!-- | Total: | 1 | --> |
| Totals | |
|---|---|
| Change from base Build 998d0ea11433b3973e23074888f4db9ffecee33e: | 0.4% |
| Covered Lines: | 133 |
| Relevant Lines: | 175 |
We particularly need
no_ack: truewhich is the only way to have guaranteed "at most once" processing with RabbitMQ. Seems fair enough to just set the acknowledger toBroadway.NoopAcknowledgerwhen:no_ackistrue.