search

dashbitco / nimble_options

A tiny library for validating and documenting high-level options. 💽
Apache License 2.0
507 stars 38 forks source link

Does type_doc do something? #100

Closed dvic closed 1 year ago

dvic commented 1 year ago

If I'm not mistaken, the type_doc option seems to be unused in the project? Maybe I'm mistaken, but I can't see any effect of using this option.

josevalim commented 1 year ago

Please send a PR to remove it? :)

dvic commented 1 year ago

Sure, no problem :) But is there (another) way to modify the outputted type spec / docs ;)? In this case i'm trying to type_doc a function. Or is this considered out of scope for now?

josevalim commented 1 year ago

which Elixir code would you be expecting it to produce?

josevalim commented 1 year ago

Oh, I see what you mean. It is something to replace the default type doc option. Yeah, an option to make that actually be used will be welcome too. Your call, please tell me which one to merge. :)

dvic commented 1 year ago

Hah okay, then I'll work on making it work ;)

aselder commented 1 year ago

Was just about to mention this... Thanks @dvic