search

dashbitco / nimble_options

A tiny library for validating and documenting high-level options. 💽
Apache License 2.0
507 stars 38 forks source link

Support redacting sensitive options #133

Closed anthonator closed 2 months ago

anthonator commented 2 months ago

Wanted to get some initial work in front of you all to make sure my approach is acceptable.

My main concern with this implementation is trying to centralize the redact logic as much as I can. Since this is a security minded feature I want to make sure that future contributors don't need to implement redaction themselves so I'm making it part of the implementation pattern for types.

Let me know if you feel like I'm on the right track or not. Open to suggestions as well.

anthonator commented 2 months ago

@whatyouhide thank you for reviewing. I'll keep moving forward with this approach.

whatyouhide commented 2 months ago

@anthonator let me know what this is ready for review 🙃

anthonator commented 2 months ago

@whatyouhide I have all code in place that redacts messages for types. Please feel free to review that. I'm working on implementing the Inspect protocol for NimbleOptions.ValidationError now. I'll make this ready for review once that's done.

anthonator commented 2 months ago

@whatyouhide this is ready for review.

whatyouhide commented 2 months ago

Thanks @anthonator 💟