Make width & height typedefs optional

dashboardphilippines / react-webcam-barcode-scanner

[UNMAINTAINED -- PLEASE USE https://github.com/jamenamcinteer/react-qr-barcode-scanner INSTEAD] A simple React Component using the client's webcam to read barcodes.

45 stars 32 forks source link

Make width & height typedefs optional #1

Open gigerbytes opened 4 years ago

gigerbytes commented 4 years ago

The library currently requires users to specify width& height parameters, so it is impossible to leave them empty and have the camera take the full width of the screen (default behaviour without width & height specified).

Fix: Make these optional, and allow string input for specifying percentages.

stamahto commented 4 years ago

Yep, I would appreciate too.

samuelpucat commented 4 years ago

setting width="100%" worked for me

Tohaker commented 4 years ago

setting width="100%" worked for me

How? The type is set to number only - it would never compile with a string

gigerbytes commented 3 years ago

@phillytan could you test thx

KayBeSee commented 3 years ago

I would appreciate this as well