search

dashboardphilippines / react-webcam-barcode-scanner

[UNMAINTAINED -- PLEASE USE https://github.com/jamenamcinteer/react-qr-barcode-scanner INSTEAD] A simple React Component using the client's webcam to read barcodes.
45 stars 32 forks source link

Disabled Microphone request for Barcode detection. #12

Open glenkleidon opened 3 years ago

glenkleidon commented 3 years ago

This is the fix for Issue 7. #7

Tested on chrome

braveheart84 commented 2 years ago

Can we have this PR merged please?

andreasanta commented 2 years ago

@phillytan @m-banik Can you please merge this? It's a blocker for our security team. Thank you!

m-banik commented 2 years ago

@andreasanta, I will, but I cannot guarantee that it won't cause any of the new issues.

andreasanta commented 2 years ago

@m-banik Thank you! What new issues are you referring to?

m-banik commented 2 years ago

Oh, I apologize. It was kind of surprise for me that I was mentioned here and I didn't recall some of the obvious facts. I have no write access and thus I cannot merge this PR.

m-banik commented 2 years ago

@andreasanta, I know the changes are few, but I don't know the entire code base. I couldn't be sure that they won't affect anything else in a way that you would not want it to. Also, in relation to the above, I made but one PR to this repo some time ago and then forgot about it. Sorry I can't be more helpful.

m-banik commented 2 years ago

@andreasanta, I see that @phillytan is indeed the correct addressee of your request.

andreasanta commented 2 years ago

@m-banik No worries, thanks very much for your help anyways!