dashcraft / OntraJs

Ontraport API interface for Javascript.

MIT License

0 stars 3 forks source link

Wip #11

Closed emukupa closed 5 years ago

emukupa commented 5 years ago

Description

Am able to process a file like structure into the required structure

Type of change

[x] New feature (non-breaking change which adds functionality)
[x ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] This change requires a documentation update

How Has This Been Tested?

Using a test runner

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[x] My code has been reviewed by at least one peer
[x] I have commented my code, particularly in hard-to-understand areas
[ ] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests that prove my fix is effective or that my feature works
[x] New and existing unit tests pass locally with my changes

dashcraft commented 5 years ago

I'm going to merge what you have so i can test it against the api going forward. But yes, we need to make sure we add all available types and parse them accordingly.