Terraforming with LeftMouseButton and Mouse movement

[GoogleCodeExporter]

I've coded terraforming like the original with hold down the right mouse button 
and then move the mouse up (leveling up) or down (leveling down) by every 10 
pixel mouse movement.

Original issue reported on code.google.com by vatriani.nn on 7 Oct 2013 at 4:00

Attachments:

• mouseterra.txt

[GoogleCodeExporter]

A few comments:

- Your patch appears to be inverted - new stuff is marked as deletions
- Some indentation issues... everywhere
- Comments are not all using proper English - capital letters and full stops 
are required :)
- "direction=0" and others needs some spaces
- if, else if, else blocks need braces
- I'm not sure why you moved the function in the file, why did you do that?

See https://code.google.com/p/freerct/wiki/CodeStyle for more details

Original comment by CharlesP...@googlemail.com on 7 Oct 2013 at 6:09

• Added labels: Type-Enhancement

[GoogleCodeExporter]

Functions where used but they are at the old position not defined (later in 
cpp-file)

I've used diff -upr and i think the files where in the wrong direction sry for 
that.
indentations -.-  my editor replaced all tabs to 2 spaces

I will fix them all and create a new patch

Original comment by vatriani.nn on 7 Oct 2013 at 6:25

[GoogleCodeExporter]

I hope the patch is valid and the CodeStyle is right

Original comment by vatriani.nn on 7 Oct 2013 at 6:55

Attachments:

• landscapeMouse.patch

[GoogleCodeExporter]

better :)

Some more:
- "pixelcounter/10" - more missing spaces
- bool terraform; - doesn't appear to be used

Your diff structure is still unusual - it'd be better if you did 'svn diff' or 
similar

However, me and Alberth are still not sure about the purpose of this patch - 
what problem are you solving with this patch, or are you just making it emulate 
original behaviour?

Original comment by CharlesP...@googlemail.com on 7 Oct 2013 at 7:03

[GoogleCodeExporter]

Original comment by CharlesP...@googlemail.com on 7 Oct 2013 at 7:11

• Added labels: Type-Patch
• Removed labels: Type-Enhancement

[GoogleCodeExporter]

I will fix again^^
It's so difficult for me to get away from my CodeStyle...
Okay i will use svn diff for now (i've used diff -upr for kernelpatches and 
they like them^^)

The patch is not an new function thats right, but i think it's easier to push a 
mousebutton and drag the mouse as uses mousewheel for terraforming. (especially 
on touchpads or touchscreens) and yes it's more emulate the orginal behaviour.

Original comment by vatriani.nn on 7 Oct 2013 at 7:16

Attachments:

• landscapeMouse.patch

[GoogleCodeExporter]

Not entirely correct, but close enough. Committed in r892.
Thank you for the patch.

Original comment by Alberth2...@gmail.com on 7 Oct 2013 at 7:51

• Changed state: Fixed