search

dashdan / freerct

Automatically exported from code.google.com/p/freerct
0 stars 0 forks source link

Install FreeRCT and RCD files with make install #33

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
What are the major things which your patch changes / adds?

In this patch you can run cmake and later install it with make install

Against what version did you make your patch?

Rev 927

Please provide any additional information below.

I attach two patches, one for install rcd files and other for install freerct

Original issue reported on code.google.com by adrian.a...@gmail.com on 27 Oct 2013 at 11:02

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by CharlesP...@googlemail.com on 28 Oct 2013 at 9:44

GoogleCodeExporter commented 9 years ago

Original comment by CharlesP...@googlemail.com on 28 Oct 2013 at 9:47

GoogleCodeExporter commented 9 years ago 
Hey, I just realised these are still here :)

I've made changes to where the executable and data files get placed ( now in 
./bin ), do you think you could update your 2 issues to reflect these changes?

Original comment by CharlesP...@googlemail.com on 30 Jun 2014 at 4:08

GoogleCodeExporter commented 9 years ago 
Hi, I've recreated the patch from zero. It enables the use of "make install" 
and it copies the freerct, rcdgen and rcd files to a bin folder. By default 
installs to /usr/local/bin/freerct

PD: I suspect that someone tried to do a manual install by creating a /bin 
folder. I didn't remove it but I think it's unneeded.

Original comment by adrian.a...@gmail.com on 3 Jul 2014 at 12:24

Attachments:

GoogleCodeExporter commented 9 years ago 
bin folder - i've been "forcing" the executables & rcd files to that folder 
mostly so they're easier to find, but i guess it's not entirely necessary. i 
think it should stay for now though

as such, i don't agree with the bin -> build change
also, shouldn't "install(TARGETS freerct DESTINATION bin)" (and others) be 
"install(TARGETS freerct DESTINATION ${CMAKE_BUILD_DIR}/bin)" ?

/usr/local/bin/freerct - IMO, not a good idea to put the executable there (just 
yet), as the config file will have to be in that folder as well (currently has 
to be next to the executable), which seems wrong

and the rcdgen version is a bit useless, although i can see how it could be 
useful in future (remove it for now though?)

Original comment by CharlesP...@googlemail.com on 3 Jul 2014 at 12:32

GoogleCodeExporter commented 9 years ago 
No, the install command destination should point to a relative folder (doesn't 
matter if exists) so you can put "make DESTDIR=/my/dir/here install" and it 
installs the virtual folder (bin, ... and so on) onto /my/dir/here. Take a look 
at CMAKE_INSTALL_PREFIX var for define a prefix between the DESTDIR path and 
the realtive folders with install command.

Original comment by adrian.a...@gmail.com on 3 Jul 2014 at 12:37