search

dasher-project / dasher

Dasher
http://www.inference.phy.cam.ac.uk/dasher/
GNU General Public License v2.0
156 stars 45 forks source link

Continous Integration for Windows #145

Closed erdemkiraz closed 6 years ago

erdemkiraz commented 6 years ago

Ref: #125 Had to change Dasher.wxs file because there wasn't any file Dasher.chm after build. As I understands it should be related with "Help" section but there is no file, and Visual Studio doesn't produce such file and doesn't show errors about it. Though, it makes a problem on Appveyor.

I checked the build with "if exist" command, maybe another command could check that too, but it does the work. I also changed "Release"s to "Debug"s in Dasher.wxs because it works properly on Visual Studio but it produces error on Appveyor.

I checked with wrong buildings(wrong expat path, etc.) and in that case Appveyor didn't build, as expected. I tried to build after my file changes, everything seems fine on Visual Studio.

The build takes 15-20 minutes on my 2GB RAM Virtual Machine Windows 10, an it takes like 10 minutes on Appveyor, which seem very enough to me.

erdemkiraz commented 6 years ago

I add commits with release configuration. It works lot faster(like in 3-4 minutes) than debug conf. I'm also planning to change to build configuration file for the "libexpat.dll" issue when running the .exe. If it's okay, I can change the installation guide and may add env. variable for debug/release option, in the forthcoming days.

erdemkiraz commented 6 years ago

Now I Changed it to an environment variable.

If "DASHERCONFIG" is "Release" then it works for release, if it's "Debug" then it works for debug. Also as you can see on https://ci.appveyor.com/project/erdemkiraz/dasher I created two jobs, for debug and release. Release took 5 mins and Debug took 10 mins. If one of them is enough, we can decrease it to one job, with deleting one configuration from matrix.

I think it's better now. Just we have to mention DASHERCONFIG in Installation guide. And currently I'm working on libexpat.dll issue, but there are lots of files interested in $EXPAT. If I can do that, I will add it too.

erdemkiraz commented 6 years ago

I resolved merge conflicts, delete DASHERCONFIG, updates the .wxs with Release also commented the part that I deleted. Now Appveyor builds with only Release and it builds properly.

I think it's good to go now.