search

dashersw / cote

A Node.js library for building zero-configuration microservices.
http://cote.js.org
MIT License
2.35k stars 187 forks source link

hiredis dependency preventing using node versions > 10? #256

Closed andrewcartwright1 closed 3 years ago

andrewcartwright1 commented 3 years ago

Hi,

I'm currently looking to use cote for a project running node 16.

I've found that to be able to install cote I need to be running node 10 and i need to manually install hiredis which is a dependency of a dependency (redis-parser) of a dependency (node) of a dependency (@dashersw/node-discover).

I was wondering what the likely hood of that base dependency (@dashersw/node-discover) being updated to use newer versions is? looking at the package.json for these packages it is no longer dependant on hiredis

Thank you

For anyone facing issues with node-gyp trying to use this package. The work around that I have been using is to downgrade to Node 10.24.1, run npm i hiredis and then change back to the version of Node that I am using.

dashersw commented 3 years ago

Hello @andrewcartwright1, I'm not sure I understand you correctly—cote installs and works well with node 16, and there doesn't need to happen any manual installations. As far as I can see, installing cote doesn't install hiredis in your package-lock.json.

andrewcartwright1 commented 3 years ago

Hi,

Thanks for getting back to me. So the issue that I was having at the time of writing this was..

I had done a npm install for cote and than ran Webpack dev server, this kept failing due to an issue with hiredis being missing.

I later traced this to some of the dependencies in cote requiring it.

I managed to resolve the issue by adding the hiredis dependency on a lower node version.

dashersw commented 3 years ago

I see, but if any dependencies of cote required hiredis, we would have seen it in package-lock.json. As far as I can tell, a clean install of cote doesn’t require hiredis.