dashersw / pedalboard.js

Open source JavaScript framework for developing audio effects for guitars using the Web Audio API.
dashersw.github.com/pedalboard.js
GNU General Public License v3.0
831 stars 97 forks source link

Out of curiousity - why "best on latest Safari, but Chrome is OK too?" Web Audio is done by Chrome team. #3

Closed cwilso closed 12 years ago

dashersw commented 12 years ago

I know :) thanks for all the efforts. Try sample 5, the sound pops because of the convolution pedal. Turn it off and the pop goes away. Somehow Safari handles it cleanly, without a pop.

cwilso commented 12 years ago

Hmm, interesting. I'm guessing that's just an artifact of the input being overdriven.

dashersw commented 12 years ago

With a very far-fetched guess, I might say it causes a buffer overflow somewhere.

cwilso commented 12 years ago

On testing again - are you hearing a DRASTIC pop, or just a boominess in the bass? I had it load once and be pretty messed up, and once it was fine except there was a hard boom in the bass that went away if I turned down the input (OD) volume.

dashersw commented 12 years ago

Actually, I hear a DRASTIC stutter, it stops playing now and then, and yes, it's tied to the level of overdrive pedal, turn it down and it goes away.

cwilso commented 12 years ago

Yeah, you're overdriving the output badly (since WA is floating point, it can be overdriven during processing without clipping - but the final outputs need to be held to a nominal -1.0 - +1.0 range. Not sure why this is behaving differently on Safari - I can't get any sound out at all on Safari 6.0 or a nightly. I'll ask Chris.